Spencer KiyA push of any branch to gitlab will trigger a CI/CD job that will check your branch for xml parsing errors, and that tags/attributes conform to acc standards. On the CI/CD page you will see a job with a blue status wheel showing that a pipeline is running:
This will take around 5 minutes. When finished you will either have a green checkmark indicating success:
Or a red 'X' indicating that something went wrong:
If a pipeline failed, the issues need to be resolved before it is merged into master. You can see the errors by clicking the red 'x' followed by 'test_acc':
This brings up a terminal-like output from the runner that executed the job. Error messages will likely be near the bottom. Resolve the issues.
In the above example there is a problem with the sequence file csb_db1.xml, and the issue is that there is an xml open tag that is missing a corresponding closing tag.
When someone requests a merge into master, you just need to check that their pipeline was successful before accepting. Navigate to the merge request page, make sure that there is a green checkmark beside the pipeline for their branch. If so, click 'Merge'.
If someone wants to merge changes and has added new attributes to a tag, their pipeline may fail. In this case:
- Review the new tags/attributes and confirm they seem necessary
- Checkout/Pull the persons dev branch
- Add the new tags/attributes to the config file 'xml_allowed_tags.ini' on their branch.
- Commit and push their branch to gitlab, confirm the pipeline passes.
- Merge their branch into master.