Skip to content

Fix small code issues

Jolie Roiseux requested to merge refactor/dofit-numbins into develop

Context

Two small tickets combined into one MR.

  • Use doFit in NTuple writer
  • Fix NumBin/NumBins confusion - NumBins ticket

Summary

  • Use doFit variable instead of check for amp == 0 as per a comment in the code.
  • NumBin in the config file was supposed to be NumBins that is being set in RunManager::createReader() and used in baseline processing (or at least that's how it was in the legacy code). I couldn't see any variable that was used to limit the bins in pulse finding in the legacy code, but if we need it for some reason, we should add a separate variable to the config so the two aren't being confused.
  • I also moved some repeated code in RunManager::createReader()

How was this tested?

Compiled and ran code and it ran as before.

Merge request reports